Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21275 )
Change subject: Skip unhealthy directories when opening DirManager ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21275/1/src/kudu/fs/dir_manager.cc File src/kudu/fs/dir_manager.cc: http://gerrit.cloudera.org:8080/#/c/21275/1/src/kudu/fs/dir_manager.cc@687 PS1, Line 687: for (int i = 0; i < loaded_instances.size(); i++) { : auto& instance = loaded_instances[i]; nit: while you at this, could you modify this code to get rid of the index and transform this 'for()' cycle for (auto& instance : loaded_instances) { ... } -- To view, visit http://gerrit.cloudera.org:8080/21275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If19d7a6eba9e755bcc81cca207f7c84a7837b07b Gerrit-Change-Number: 21275 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Comment-Date: Tue, 09 Apr 2024 20:56:44 +0000 Gerrit-HasComments: Yes
