Hello Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21321
to look at the new patch set (#2).
Change subject: [util] expose recently seen value in a histogram
......................................................................
[util] expose recently seen value in a histogram
When troubleshooting a performance issue with a Kudu cluster, I found it
would be useful if each of the existing histogram metrics exposed most
recently seen value (in particular, I was interested in knowing
the most recently captured length of a tablet's prepare queue).
This does not align with the semantics of a histogram since collected
statistics on the distribution of observed values aren't supposed to
include any notion of recency. However, I think this is a useful
improvement from the observability standpoint because it allows for
collection of valuable information on monitored parameters
without introducing additional metrics.
NOTE: even if chromium-based Atomics are obsolete and STL atomics
should be used in new code instead, I opted to use the former
because it would look much uglier otherwise. I think
it's a better option to switch to using STL atomics in
hdr_histogram.{h,cc} altogether in a separate changelist.
Change-Id: Ia4547faba050e09e31c83372105a9fe97b77ccbc
---
M src/kudu/util/hdr_histogram-test.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/histogram.proto
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
6 files changed, 39 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/21321/2
--
To view, visit http://gerrit.cloudera.org:8080/21321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4547faba050e09e31c83372105a9fe97b77ccbc
Gerrit-Change-Number: 21321
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
