Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21360 )
Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21360/2//COMMIT_MSG Commit Message: PS2: Thank you for the write up -- I must admit I haven't read it yet to digest everything, but I'm planning to do so when I can allocate more time for this. The only feedback at this point from my side is that the test is still failing even with this fix: src/kudu/tablet/compaction-test.cc:910: Failure Value of: JoinStrings(sink.logged_msgs(), "\n") Expected: has substring "removed from compaction input due to memory constraints" Actual: "I20240503 09:52:40.236797 953582 compaction-test.cc:904] CompactRowSetsOp complete. Timing: real 0.872s\tuser 0.844s\tsys 0.028s Metrics: {\"bytes_written\":4817,\"cfile_cache_hit\":90,\"cfile_cache_hit_bytes\":4310,\"cfile_cache_miss\":330,\"cfile_cache_miss_bytes\":3794180,\"cfile_init\":41,\"delta_iterators_relevant\":40,\"dirs.queue_time_us\":1303,\"dirs.run_cpu_time_us\":824,\"dirs.run_wall_time_us\":844,\"drs_written\":1,\"lbm_read_time_us\":4281,\"lbm_reads_lt_1ms\":494,\"lbm_write_time_us\":4794,\"lbm_writes_lt_1ms\":132,\"mutex_wait_us\":223,\"num_input_rowsets\":10,\"peak_mem_usage\":2147727,\"rows_written\":20,\"spinlock_wait_cycles\":83584,\"thread_start_us\":418,\"threads_started\":7}" I20240503 09:52:40.240758 953582 test_util.cc:175] ----------------------------------------------- I20240503 09:52:40.240803 953582 test_util.cc:176] Had fatal failures, leaving test files at /tmp/kudutest-0/compaction-test.TestCompaction.TestRowSetCompactionSkipWithBudgetingConstraints.1714755106413846-953582-0 -- To view, visit http://gerrit.cloudera.org:8080/21360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df218cd2d8ef3709793db267d5a0d651421dbb6 Gerrit-Change-Number: 21360 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Fri, 03 May 2024 16:57:19 +0000 Gerrit-HasComments: Yes
