Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 )
Change subject: [metrics] Add tablet level metrics for scans op time ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21291/3/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/21291/3/src/kudu/tserver/tablet_server-test.cc@2290 PS3, Line 2290: ASSERT_FALSE(wall_tmp == nit: ASSERT_NE or ASSERT_GT Similar to the following 3 ASSERTs. http://gerrit.cloudera.org:8080/#/c/21291/3/src/kudu/tserver/tablet_server-test.cc@2317 PS3, Line 2317: Do you mind to add some comments to describe the purpose of each newly added tests? -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Sat, 11 May 2024 02:48:42 +0000 Gerrit-HasComments: Yes
