Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 )
Change subject: [metrics] Add metrics for tablet copy op time ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21356/6/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: http://gerrit.cloudera.org:8080/#/c/21356/6/src/kudu/tserver/tablet_copy_client.h@197 PS6, Line 197: const tablet::TabletMetrics* TabletMetrics() { return tablet_metrics_; } Is this necessary? It seems TabletMetrics() is only used in TabletCopyClient class, we can access tablet_metrics_ directly. -- To view, visit http://gerrit.cloudera.org:8080/21356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c Gerrit-Change-Number: 21356 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Sat, 11 May 2024 03:18:52 +0000 Gerrit-HasComments: Yes
