Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21415 )
Change subject: [common] get rid of MutexLock ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > My only concern/nit about this change is wether we're loosing a bit of code > readability, many places a simple "lock" is used for name, and the > information about the type of the lock is a bit harder to find out (e.g. have > to look up the header file and find the lock declaration to see the lock > type). > It's not a huge issue, and renaming every instance to more specific names > seems excessive, just wanted to bring it up and hear your thoughts. I think I have to clarify a bit, I meant that using 'decltype(insert-lock-name)' hides the lock type information, but I might be just splitting hairs here :) -- To view, visit http://gerrit.cloudera.org:8080/21415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e0ef2c688ef8be74d018bb9bffe70b6655e654 Gerrit-Change-Number: 21415 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Mon, 13 May 2024 08:47:45 +0000 Gerrit-HasComments: No
