Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21411 )
Change subject: Leader rebalance ignores soft deleted tables ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer-test.cc@592 PS4, Line 592: // The soft deleted table is not leader rebalanced. nit: Move this line under 'if (FLAGS_leader_rebalancing_ignore_soft_deleted_tables)' clause. http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/auto_leader_rebalancer.cc@91 PS4, Line 91: Whether to rebalance Miss "ignore"? http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/21411/4/src/kudu/master/catalog_manager.h@881 PS4, Line 881: GetActiveTables How about naming as 'GetNormalizedTables()'? Now 'normalized' and 'soft_deleted' are used to distinguish the tables, it would be better to unify the names. -- To view, visit http://gerrit.cloudera.org:8080/21411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e2f37b004ed7d394e18d21cce97a2c9702adba3 Gerrit-Change-Number: 21411 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Tue, 21 May 2024 02:27:24 +0000 Gerrit-HasComments: Yes
