Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21446 )
Change subject: Fix deadlock on fail for CBTree-test ...................................................................... Patch Set 3: (3 comments) Overall looks good. just a few nits. http://gerrit.cloudera.org:8080/#/c/21446/3/src/kudu/tablet/cbtree-test.cc File src/kudu/tablet/cbtree-test.cc: http://gerrit.cloudera.org:8080/#/c/21446/3/src/kudu/tablet/cbtree-test.cc@451 PS3, Line 451: num_threads + 1 just curious, why is count initialised to 1 extra than number of threads? http://gerrit.cloudera.org:8080/#/c/21446/3/src/kudu/tablet/cbtree-test.cc@483 PS3, Line 483: go_barrier.Wait() Here and at line 748, make sure extra barrier wait is ok. http://gerrit.cloudera.org:8080/#/c/21446/3/src/kudu/tablet/cbtree-test.cc@485 PS3, Line 485: thread & thread & -> thread& -- To view, visit http://gerrit.cloudera.org:8080/21446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia10d05dfdc4a12cb034450f432693f054d138498 Gerrit-Change-Number: 21446 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 May 2024 12:35:19 +0000 Gerrit-HasComments: Yes
