Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 )
Change subject: KUDU-1261 Java client complex type introduction ...................................................................... Patch Set 4: (1 comment) Just a first quick look; I'm going to take a closer look. http://gerrit.cloudera.org:8080/#/c/20749/4/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/20749/4/src/kudu/common/common.proto@106 PS4, Line 106: required Make this field optional: * it cannot be required if thinking about Proto3 * if you decide to expand this later on, you might find this isn't going to work (e.g., think about embedded data types) -- To view, visit http://gerrit.cloudera.org:8080/20749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92825c4ab430ccd4bbd902b06679488af91d9804 Gerrit-Change-Number: 20749 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Thu, 30 May 2024 20:18:00 +0000 Gerrit-HasComments: Yes
