Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 )
Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 ...................................................................... Patch Set 21: (6 comments) http://gerrit.cloudera.org:8080/#/c/21030/21//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21030/21//COMMIT_MSG@8 PS21, Line 8: Can you add some information about why this was necessary and what does this solve in addition to the list of changes? http://gerrit.cloudera.org:8080/#/c/21030/21/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/21/java/build.gradle@a72 PS21, Line 72: is this not needed anymore? http://gerrit.cloudera.org:8080/#/c/21030/20/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/21030/20/java/gradle/publishing.gradle@72 PS20, Line 72: } nit: add an empty line http://gerrit.cloudera.org:8080/#/c/21030/21/java/gradle/shadow.gradle File java/gradle/shadow.gradle: http://gerrit.cloudera.org:8080/#/c/21030/21/java/gradle/shadow.gradle@71 PS21, Line 71: nit: remove this empty line http://gerrit.cloudera.org:8080/#/c/21030/21/java/gradlew File java/gradlew: PS21: I assume this file is generated by Gradle and doesn't have to be reviewed, is this correct? http://gerrit.cloudera.org:8080/#/c/21030/21/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/21030/21/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@238 PS21, Line 238: // setting up log capture for the class that generates the logs we're nit: Capitalize and add a period at the end of the sentence like the others. Same for the other instances. -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 21 Gerrit-Owner: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Jun 2024 07:29:52 +0000 Gerrit-HasComments: Yes
