Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 )
Change subject: [ARM] Concurrent binary tree memory barriers fixed. ...................................................................... Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG@45 PS6, Line 45: > nit: these Done http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG@47 PS6, Line 47: eve > nit: C++ Done http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG@72 PS6, Line 72: should be supported by both Clang and GCC. > How so? What's the size of LeafNode and InternalNode after removing the pa Packed is no longer removed in newer versions. It was a mistake to do so, since unaligned other structures are added into the same arena http://gerrit.cloudera.org:8080/#/c/21127/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/14//COMMIT_MSG@43 PS14, Line 43: versi > nit: formatting Done http://gerrit.cloudera.org:8080/#/c/21127/14//COMMIT_MSG@55 PS14, Line 55: lut > nit: were Done http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h@139 PS6, Line 139: * > nit: add space Done http://gerrit.cloudera.org:8080/#/c/21127/6/src/kudu/tablet/concurrent_btree.h@378 PS6, Line 378: > Just for my understanding, what is the difference between StableVersionAcqu StableVersion waits until a node is not locked (Only nodes under modification are locked), reading never locks. -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 15 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Jun 2024 11:25:54 +0000 Gerrit-HasComments: Yes
