Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 21: (4 comments) Created new SLRUHandle to mimic RLHandle to resolve the ASAN issues. Any new field in the RLHandle resulted in ASAN issues in codegen. http://gerrit.cloudera.org:8080/#/c/20607/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20607/20//COMMIT_MSG@23 PS20, Line 23: Ran cache benchmarks for RELEASE build > nit: please also note whether you were using the default flag settings or t Done http://gerrit.cloudera.org:8080/#/c/20607/20//COMMIT_MSG@25 PS20, Line 25: Build ran locally on macOS, 6 cores and 2.6GHz. > It would be great to add a few patterns into the cache-bench.cc that clearl That's a good idea considering the SLRU cache doesn't perform better even for the ZIPFIAN distributions. I'll work on this for the next revision. http://gerrit.cloudera.org:8080/#/c/20607/20/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench.cc: http://gerrit.cloudera.org:8080/#/c/20607/20/src/kudu/util/cache-bench.cc@60 PS20, Line 60: 3 > nit: did you experiment with other settings for the protected segment looku Changed value to 3, ran the benchmarks again and updated commit message. The hit rates for all workloads are the same, the throughput lags though. http://gerrit.cloudera.org:8080/#/c/20607/20/src/kudu/util/slru_cache.cc File src/kudu/util/slru_cache.cc: http://gerrit.cloudera.org:8080/#/c/20607/20/src/kudu/util/slru_cache.cc@400 PS20, Line 400: int key_len = key.size(); > nit: this could be replaced with the following in the header file Done -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 21 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 07 Jun 2024 22:48:35 +0000 Gerrit-HasComments: Yes
