Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 )
Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21295/4/src/kudu/fs/dir_manager.h File src/kudu/fs/dir_manager.h: http://gerrit.cloudera.org:8080/#/c/21295/4/src/kudu/fs/dir_manager.h@478 PS4, Line 478: // Set o > Well, std::unordered_set has high 'initial price' when it allocates its buc Hahaha, yes, std::set is more suitable here, reverted. http://gerrit.cloudera.org:8080/#/c/21295/5/src/kudu/fs/dir_manager.cc File src/kudu/fs/dir_manager.cc: http://gerrit.cloudera.org:8080/#/c/21295/5/src/kudu/fs/dir_manager.cc@227 PS5, Line 227: LOG(WARNING) << s.ToString(); > Are we sure this is done only when 's' contains non-OK status? Otherwise, Updated the code to make it more clear. Because it short returned above when 'metadata_file_' is unhealthy, so here it must be healthy(in OK status), and the code is short, not needed to add DCHECK(). -- To view, visit http://gerrit.cloudera.org:8080/21295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4bffc6b902ab96edf0ca6c44f51c8db2670d52 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 12 Jun 2024 15:26:27 +0000 Gerrit-HasComments: Yes
