Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 )
Change subject: Include table UUID when using --show_table_info ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21496/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/21496/4/src/kudu/tools/tool_action_table.cc@340 PS4, Line 340: values.push_back(mapping.find(columns[i])->second(tinfo)); what happens if I set --columns=id,nameeeee ? Will it result in a crash? I think you should either return a bad status here if mapping.find[colums[i]] == mapping.end() or validate the elements of the columns vector before calling the function. -- To view, visit http://gerrit.cloudera.org:8080/21496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I324b920e6feb6139e7d884e3cf08069b0cb922a4 Gerrit-Change-Number: 21496 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Jun 2024 16:01:26 +0000 Gerrit-HasComments: Yes
