Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 )
Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines ...................................................................... Patch Set 7: (2 comments) > Patch Set 7: Code-Review+1 > > Overall LGTM. Other than some comments in PS3 are not resolved yet. Done. http://gerrit.cloudera.org:8080/#/c/21287/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21287/3//COMMIT_MSG@7 PS3, Line 7: the crash bug when run binaries > nit: Fix the crash caused when binaries run Done http://gerrit.cloudera.org:8080/#/c/21287/3//COMMIT_MSG@15 PS3, Line 15: This patch enables the PORTABLE option when building : librocksdb to fix the issue. > It would be great if you could expand this a little bit to explain how PORT Added a link. -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:01:22 +0000 Gerrit-HasComments: Yes