Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21490 )
Change subject: [metrics] Add metrics for tablet replica election ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21490/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/21490/1/src/kudu/integration-tests/raft_consensus-itest.cc@2805 PS1, Line 2805: // failed_elections_since_stable_leader faster. This comment seems not related to this test case. http://gerrit.cloudera.org:8080/#/c/21490/1/src/kudu/integration-tests/raft_consensus-itest.cc@2812 PS1, Line 2812: "--leader_failure_max_missed_heartbeat_periods=20", Is this flag necessary for this test case? -- To view, visit http://gerrit.cloudera.org:8080/21490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d501b514e90461998bbc64f77f2bb12805ebfaa Gerrit-Change-Number: 21490 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 21 Jun 2024 07:16:05 +0000 Gerrit-HasComments: Yes
