Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21509 )

Change subject: Fix cache cleaning in dense_node-itest
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21509/4/src/kudu/util/os-util.cc
File src/kudu/util/os-util.cc:

http://gerrit.cloudera.org:8080/#/c/21509/4/src/kudu/util/os-util.cc@137
PS4, Line 137: Status FreeSlabObjectsAndPagecache() {
             :   return Env::Default()->EchoToFile("/proc/sys/vm/drop_caches", 
"3", 1);
             : }
Can make this function more common? Status DropCache(Mode mode).
mode = 1 or 2 or 3. See https://www.kernel.org/doc/Documentation/sysctl/vm.txt



--
To view, visit http://gerrit.cloudera.org:8080/21509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f36f5a97d9a032aeb495989b4dc05191bf66425
Gerrit-Change-Number: 21509
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 03:00:16 +0000
Gerrit-HasComments: Yes

Reply via email to