Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21543 )
Change subject: [cfile] allocate CFileWriter field on the stack when possible ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21543/1/src/kudu/cfile/cfile_util.h File src/kudu/cfile/cfile_util.h: http://gerrit.cloudera.org:8080/#/c/21543/1/src/kudu/cfile/cfile_util.h@98 PS1, Line 98: WriterOptionsBuilder& block_restart_interval(int interval) noexcept; > nit: Alignment, the following lines are the same. Done -- To view, visit http://gerrit.cloudera.org:8080/21543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I910c8dfac88cb1018d76ead20034fdae355a1d4c Gerrit-Change-Number: 21543 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Mon, 01 Jul 2024 17:54:55 +0000 Gerrit-HasComments: Yes
