Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 )
Change subject: Update CMake to 3.22.6 ...................................................................... Patch Set 2: > Is the cmake_minimum_required in ./CMakeLists.txt needed to be > updated as well? Thanks for pointing it out. I don't know. It was not updated in the previous cmake updates. In case you use the provided cmake from thirdparty for thirdparty build, but use an older one from your system, kudu might compile. It seems logical for me to increase it. I will ad @Alexey to the review. -- To view, visit http://gerrit.cloudera.org:8080/21569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I563e188b6692ebfe0e0b3e98577961a8380f1f31 Gerrit-Change-Number: 21569 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jul 2024 07:30:15 +0000 Gerrit-HasComments: No