Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21481 )
Change subject: [KUDU-3583] Revert the default value of the flag --tablet_history_max_age_sec ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21481/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21481/2//COMMIT_MSG@10 PS2, Line 10: --tablet_history_max_age_sec to 15 minutes to avoid write amplifications > I guess there isn't a trade-off that fits every use case. There was an att I remember we had this discussion over slack a while back. The only concern is that after changing it back to 15 minutes, we might start getting customer issues where they are not able to scan old updates. However, I agree that the benefits from decreasing the value are quite worthy, maybe even more. Along with having follow-up patches to introduce more meaningful message, we could also document the fact so that customer who have been relying on default value of 7 days are aware of this change and can make informed decision as far as scanning requirement for old updates is concerned. That way they can avoid running into the situation in the first place. -- To view, visit http://gerrit.cloudera.org:8080/21481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63556578bafe2bd49136850f488bd3b656728a4a Gerrit-Change-Number: 21481 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Jul 2024 07:54:21 +0000 Gerrit-HasComments: Yes
