Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 )
Change subject: KUDU-3594 Fix scan_token-test on ASAN ...................................................................... Patch Set 1: (1 comment) thank you for the fix! http://gerrit.cloudera.org:8080/#/c/21610/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/21610/1/src/kudu/client/scan_token-test.cc@1747 PS1, Line 1747: STLDeleteValues(&ts_map); nit: it would be more bullet-proof if put into a ScopedCleanup auto cleanup = MakeScopedCleanup([&] { STLDeleteValues(&ts_map); }); -- To view, visit http://gerrit.cloudera.org:8080/21610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f807c7b6cdb34b85fd861bb557ae46a78417371 Gerrit-Change-Number: 21610 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2024 16:41:05 +0000 Gerrit-HasComments: Yes
