Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21654 )
Change subject: [util] modernize MemTracker ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21654/1/src/kudu/util/mem_tracker-test.cc File src/kudu/util/mem_tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/21654/1/src/kudu/util/mem_tracker-test.cc@351 PS1, Line 351: SKIP_IF_SLOW_NOT_ALLOWED(); > nit: I'm a bit of confused how this test would be very low? It turned to be related to the kernel.core_pattern setting: if the core files generated in death tests scenarios are piped through systemd-coredump for special handing, it might take quite a long time to run through {ASSERT,EXPECT}_DEATH assertion. I'm going to remove this update from this patch, and handle that part separately. -- To view, visit http://gerrit.cloudera.org:8080/21654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e154055891cbec0a21a852629e8ed11ee61df1 Gerrit-Change-Number: 21654 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 10 Aug 2024 05:49:37 +0000 Gerrit-HasComments: Yes
