Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21692 )

Change subject: [java] Fix build failures
......................................................................


Patch Set 1:

(3 comments)

Thank you for addressing this!

http://gerrit.cloudera.org:8080/#/c/21692/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21692/1//COMMIT_MSG@10
PS1, Line 10: when building java due to depedency not present:
I guess the reason is the jcenter's sun-setting:
  https://jfrog.com/blog/jcenter-sunset/

Does it make sense to mention that in the commit message?


http://gerrit.cloudera.org:8080/#/c/21692/1//COMMIT_MSG@17
PS1, Line 17: dependency's groupId to be fetched.
Just in case: did you verify building Kudu in the 1.16.x branch works with this 
patch?


http://gerrit.cloudera.org:8080/#/c/21692/1/java/buildSrc/build.gradle
File java/buildSrc/build.gradle:

http://gerrit.cloudera.org:8080/#/c/21692/1/java/buildSrc/build.gradle@22
PS1, Line 22:   jcenter()
Does it make sense to remove this repo since it's been sunset as of 2024-08-15?

https://jfrog.com/blog/jcenter-sunset/



--
To view, visit http://gerrit.cloudera.org:8080/21692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice7309262c9d9f7c10772dee01b5ebf3843efcef
Gerrit-Change-Number: 21692
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Aug 2024 05:43:45 +0000
Gerrit-HasComments: Yes

Reply via email to