Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21722 )
Change subject: [util] fine-grained versioning for diagnostic socket ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc File src/kudu/rpc/acceptor_pool.cc: http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/rpc/acceptor_pool.cc@97 PS3, Line 97: -1, nit: alignment. http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc File src/kudu/util/net/diagnostic_socket.cc: http://gerrit.cloudera.org:8080/#/c/21722/3/src/kudu/util/net/diagnostic_socket.cc@83 PS3, Line 83: Status DiagnosticSocket::Init() { Is the DiagnosticSocket to be used in a cut mode or completely can not be used? If it can not be used, how about creating and using the object only when KUDU_HAS_DIAGNOSTIC_SOCKET is enabled like: #if defined(KUDU_HAS_DIAGNOSTIC_SOCKET) DiagnosticSocket diag_socket_; #endif -- To view, visit http://gerrit.cloudera.org:8080/21722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fad2ad5c5a177678f52bff080429568a20ac67c Gerrit-Change-Number: 21722 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Mon, 26 Aug 2024 06:53:47 +0000 Gerrit-HasComments: Yes
