Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21731 )
Change subject: [java][build] KUDU-3610: kudu-client.jar dependencies ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/21731/6//COMMIT_MSG Commit Message: PS6: BTW, did you try to run something like ./gradlew :kudu-client:dependencies before and after this patch? Did you find the results as you expected? http://gerrit.cloudera.org:8080/#/c/21731/6/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/21731/6/java/gradle/publishing.gradle@73 PS6, Line 73: // fix pom : pom.withXml { : def apiDeps = project.configurations.api.allDependencies : def shadedDeps = project.configurations.shadow.allDependencies : def finalDeps = apiDeps - shadedDeps : asNode().dependencies.dependency.findAll{ : finalDeps.findAll{ dep -> : dep.name == it.artifactId*.value()[0][0] : } : }.each() { : logger.info "Removing: ${it.artifactId*.value()[0][0]} from pom" : assert it.parent().remove(it) : } : } Why is this necessary? http://gerrit.cloudera.org:8080/#/c/21731/6/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/21731/6/java/kudu-client/build.gradle@27 PS6, Line 27: api libs.protobufJava Probably, I should have asked this question while reviewing http://gerrit.cloudera.org:8080/21030, but too much stuff was mixed together in there. Anyways, the question still remains: why to have this libs.protobufJava dependency for kudu-client when ":kudu-proto" is already dependent on it? -- To view, visit http://gerrit.cloudera.org:8080/21731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da Gerrit-Change-Number: 21731 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Sep 2024 22:31:03 +0000 Gerrit-HasComments: Yes
