Hello KeDeng,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21855
to review the following change.
Change subject: KUDU-3619 disable KUDU-3367 behavior by default
......................................................................
KUDU-3619 disable KUDU-3367 behavior by default
As it turned out, KUDU-3367 has introduced a regression due to
a deficiency in its implementation, where major compactions would fail
with errors like below if it had kicked in:
Corruption: Failed major delta compaction on RowSet(1): No min key found:
CFile base data in RowSet(1)
Since KUDU-3367 isn't quite relevant in Kudu versions of 1.12.0 and
newer when working with data that supports live row count (see
KUDU-1625), a quick-and-dirty fix is to set the default value for the
corresponding flag --all_delete_op_delta_file_cnt_for_compaction
to a value that effectively disables KUDU-3367 behavior.
This patch does exactly so.
Change-Id: Iec0719462e379b7a0fb05ca011bb9cdd991a58ef
Reviewed-on: http://gerrit.cloudera.org:8080/21848
Reviewed-by: KeDeng <kdeng...@gmail.com>
Tested-by: Alexey Serbin <ale...@apache.org>
(cherry picked from commit 3666d2026d48adb5ff636321ef22320a8af5facb)
Conflicts:
src/kudu/tablet/delta_tracker.cc
---
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/diskrowset-test.cc
2 files changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/21855/1
--
To view, visit http://gerrit.cloudera.org:8080/21855
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec0719462e379b7a0fb05ca011bb9cdd991a58ef
Gerrit-Change-Number: 21855
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: KeDeng <kdeng...@gmail.com>
