Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21861 )

Change subject: [3rd-party] bump curl version up to 8.10.1
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21861/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/21861/1/thirdparty/build-definitions.sh@791
PS1, Line 791: --without-apple-idn
> Any reasoning behind the introduction of this flag/parameter?
The same as other 'without' and 'disable' -- we are building minimalistic 
library.  That helps to avoid minimize the size of the library and the exposure 
surface for various security issues.

That's in lines 751-753 above.


http://gerrit.cloudera.org:8080/#/c/21861/1/thirdparty/build-definitions.sh@797
PS1, Line 797: libuv 
> Any reasoning behind the introduction of this flag/parameter?
ditto



--
To view, visit http://gerrit.cloudera.org:8080/21861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681fb459e3c5907febcd8cd5a3204196060a2ff7
Gerrit-Change-Number: 21861
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Fri, 27 Sep 2024 23:22:17 +0000
Gerrit-HasComments: Yes

Reply via email to