Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21823 )
Change subject: [WIP] KUDU-3608 REST API ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21823/2/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21823/2/src/kudu/master/master_path_handlers.cc@116 PS2, Line 116: void MasterPathHandlers::HandleAPI(const Webserver::WebRequest& req, : Webserver::PrerenderedWebResponse* resp) { [question for later]: put a todo here that we also need to thing about how to organize different rest catalog endpoints: one master handler or spread them http://gerrit.cloudera.org:8080/#/c/21823/2/src/kudu/master/master_path_handlers.cc@118 PS2, Line 118: if (req.request_method == "GET") this get request part seems to be okay. can you please take a look at master server test? we have existing tests that hit a given endpoint and assert the response, for example: https://github.com/apache/kudu/blob/bfa875c00d657b8d5c37ed2032cf82c6c5704f37/src/kudu/master/master-test.cc#L2381C1-L2392C2 can you take a stab and try to implement such a test for the GET request? http://gerrit.cloudera.org:8080/#/c/21823/2/src/kudu/master/master_path_handlers.cc@163 PS2, Line 163: CreateTableRequestPB request; : CreateTableResponsePB response; : // TODO: parse the post_data and fill the request object iiuc we just put together the api response, but we do not send the populated CreateTableResponsePB right? Can you look for other places to figure out how to send the create table RPC, in order to actually create the table? let us know if you need help with this. -- To view, visit http://gerrit.cloudera.org:8080/21823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67f964c4f950edfde31772cafd5c3ed5d6b87413 Gerrit-Change-Number: 21823 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <lotzgabrie...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Sep 2024 12:44:35 +0000 Gerrit-HasComments: Yes
