Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21891 )
Change subject: [fs] fix fs_manager-test on macOS ...................................................................... [fs] fix fs_manager-test on macOS Before this patch, some of the FsManagerTestBase.TestBaseOperations scenarios would crash with fatal error like below: F20241003 10:52:21.062906 1722713 data_dirs.cc:290] Check failed: "file" == opts_.dir_type (file vs. logr) This is a follow-up to 4da8b20070a7c0070a1829dfd50fdc78cad88b6a. I also updated BlockManagerOptions to use the benefits of C++17. Change-Id: I9d7101a9ab16a009978f5abfd71dd68490a251f0 Reviewed-on: http://gerrit.cloudera.org:8080/21885 Tested-by: Marton Greber <[email protected]> Reviewed-by: Marton Greber <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> (cherry picked from commit 587046b32289851d4b7e8c60067b34d7f81a561b) Reviewed-on: http://gerrit.cloudera.org:8080/21891 Tested-by: Abhishek Chennaka <[email protected]> --- M src/kudu/fs/block_manager.cc M src/kudu/fs/block_manager.h M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc 4 files changed, 32 insertions(+), 27 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: merged Gerrit-Change-Id: I9d7101a9ab16a009978f5abfd71dd68490a251f0 Gerrit-Change-Number: 21891 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
