Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21919 )
Change subject: [tests] fix a misprint
......................................................................
[tests] fix a misprint
Tests should use ASSERT_NE(), not DCHECK_NE().
This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac.
P.S.
This also fixes C++ build on macOS 14.5 for this 1.17.x branch with
Xcode 15.3. There was a linker error like below without this patch:
Undefined symbols for architecture x86_64:
"void
google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char,
std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t,
kudu::cluster::ExternalTabletServer*>(std::nullptr_t const&,
kudu::cluster::ExternalTabletServer* const&, char const*) in
disk_reservation-itest.cc.o
ld: symbol(s) not found for architecture x86_64
Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Reviewed-on: http://gerrit.cloudera.org:8080/21229
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit ab368443d276006e93370a5b6bd5862eea2475fe)
Reviewed-on: http://gerrit.cloudera.org:8080/21919
Tested-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/integration-tests/disk_reservation-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
