Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21935 )
Change subject: [dynamic_multi_master-test] reduce the amount of generated data ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21935/2/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/21935/2/src/kudu/master/dynamic_multi_master-test.cc@1833 PS2, Line 1833: quite a long time > Do we want to skip slow tests in that case using SKIP_IF_SLOW_NOT_ALLOWED() That's a good point. Yep, I can take a closer look at this and other scenarios, adding SKIP_IF_SLOW_NOT_ALLOWED() where needed (e.g., where the runtime is 3 seconds and more). I will post it in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/21935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0f0005b8f3384ad05eee6bf65e17a0e4ed289f1 Gerrit-Change-Number: 21935 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 16:58:51 +0000 Gerrit-HasComments: Yes
