Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21622 )
Change subject: KUDU-3595: Add interface to set rpc_max_message_size for C++ client ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21622/5/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/21622/5/src/kudu/rpc/connection.cc@530 PS5, Line 530: rpc_max_size > This way it is a one time thing during initialisation instead of passing ar Why? What are the benefits of introducing a member field that's not used anywhere else? I don't see any benefits neither from semantic nor implementation point of view. http://gerrit.cloudera.org:8080/#/c/21622/5/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/21622/5/src/kudu/rpc/transfer.cc@136 PS5, Line 136: C max message size flag value is $2" > This is for debug purpose only. Have you finished debugging? If yes, then remove it. -- To view, visit http://gerrit.cloudera.org:8080/21622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8feb5ba92ea604442a643e3286944564e655fa6 Gerrit-Change-Number: 21622 Gerrit-PatchSet: 6 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 17:33:19 +0000 Gerrit-HasComments: Yes
