Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21956 )
Change subject: KUDU-613: Fix minor metrics related bug ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21956/1//COMMIT_MSG Commit Message: PS1: > Do you mind adding a unit test to cover this? That should help to catch re I'm having trouble doing so, I can only access the high-level cache metrics in the testing code, not the segment-level metrics which we need to verify that the right shard is releasing the handle. I can only access the metrics that are part of CacheMetrics since that's what used in Cache::SetMetrics and the SLRUCache extends that implementation. The reference to the metrics is also a unique pointer so the only copy of the pointer can be in the cache (I can't store another copy in the testing code, so the only way to access the metrics would be through the slru_cache itself). Please let me know if you have any other ideas or if I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/21956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88 Gerrit-Change-Number: 21956 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 20:16:39 +0000 Gerrit-HasComments: Yes
