Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22028 )
Change subject: [tablet] micro-updates on DiskRowSet and related classes ...................................................................... [tablet] micro-updates on DiskRowSet and related classes This patch changes RollingDiskRowSetWriter::GetWrittenRowSetMetadata() to return a const reference to RowSetMetadataVector instead of copying its contents into the output parameter. Also, it makes CHECK/DCHECK assertions more consistent the patch brings the code in compliance with the project's C++ code style and other unsorted updates. This patch doesn't contain any functional modifications. Change-Id: I1797634c67b4eb0214fbbbd8af4aea5236054ec9 Reviewed-on: http://gerrit.cloudera.org:8080/22028 Tested-by: Kudu Jenkins Reviewed-by: Gabriella Lotz <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h 6 files changed, 75 insertions(+), 83 deletions(-) Approvals: Kudu Jenkins: Verified Gabriella Lotz: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1797634c67b4eb0214fbbbd8af4aea5236054ec9 Gerrit-Change-Number: 22028 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
