Hello Ashwani Raina, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22187
to look at the new patch set (#5).
Change subject: [thirdparty] upgrade chrony up to 4.6.1 version
......................................................................
[thirdparty] upgrade chrony up to 4.6.1 version
With chrony 4.6.1, the following has changed at the Kudu side:
* The chrony-no-superuser.patch is no longer needed since a new '-U'
command line option is now available to run chronyd when running
tests under regular (non-super-user) accounts.
* The SO_REUSEPORT socket option is now utilized by chronyd itself for
its own purposes, so the chrony-reuseport.patch removes some
limitations to let chronyd run under Kudu test scaffolding.
* It seems the behavior of finding suitable (a.k.a. selectable)
sources among configured NTP servers has changed, and chronyd 4.6.1
is less picky than chronyd 3.5. To address that, the 'minsources'
directive is added when running chronyd in client-only mode to allow
for existing test scenarios run unmodified.
* Apparently, chronyd's behavior w.r.t. determining selectable time
sources has changed between 3.5 and 4.6.1, and that manifests itself
in a few existing test scenarios when clocks of reference NTP
servers are far apart from each other or some even unsynchronized.
To address that, corresponding test scenarios have been updated
as necessary.
* chronyd 4.6.1 correctly reports an error in its configuration when
seeing multiple servers that would occupy the same configuration
slot. Since it's not possible to bind and listen at arbitrary
loopback IP addresses (127.0.0.0/8) on macOS, various test scenarios
involving multiple chronyd servers aren't run on macOS anymore.
* Since we aren't interested in exploring IPv6 support in chrony 4.6.1
at this particular moment, the '-4' option is added to both chronyd
and chronyc command lines to work only in IPv4 domain to avoid
unexpected behavior when running tests on machines with IPv6 stack
enabled.
Change-Id: I3d2dc0145f4af0ff5488bef95d0ab6544038285e
---
M src/kudu/clock/ntp-test.cc
M src/kudu/clock/test/mini_chronyd-test.cc
M src/kudu/clock/test/mini_chronyd.cc
M thirdparty/download-thirdparty.sh
D thirdparty/patches/chrony-no-superuser.patch
M thirdparty/patches/chrony-reuseport.patch
M thirdparty/vars.sh
7 files changed, 68 insertions(+), 70 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/22187/5
--
To view, visit http://gerrit.cloudera.org:8080/22187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d2dc0145f4af0ff5488bef95d0ab6544038285e
Gerrit-Change-Number: 22187
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
