Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG@7 PS4, Line 7: countdown_latch nit: you can just use [util] here instead and expand a bit in the subject (i.e. Add lock to countdown latch). Also, if there's a JIRA, maybe a separate tag is not necessary at all. http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h File src/kudu/util/countdown_latch.h: http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h@133 PS4, Line 133: mutable std::shared_timed_mutex destruction_lock_; Why do we need a separate mutex for this? Can't we just use lock_? -- To view, visit http://gerrit.cloudera.org:8080/22158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8 Gerrit-Change-Number: 22158 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Dec 2024 17:54:01 +0000 Gerrit-HasComments: Yes
