Derek Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables ...................................................................... Patch Set 5: (1 comment) > (1 comment) > > Thank you for the patch! > > Overall it looks good to me, just a tiny nit in the newly added > test. > > BTW, did you try to run the updated `kudu cluster rebalance` tool > against a real cluster? I have tested the updated cluster rebalance tool on a real cluster running a modified version of Kudu (based on Kudu 1.15, cherry-picked commits relevant to range rebalancing). And it worked :) http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc@2407 PS4, Line 2407: ASSERT_EQ(1, table_names.size()) > nit for here and below: consider making the expected/reference to be the fi fixed -- To view, visit http://gerrit.cloudera.org:8080/22239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267 Gerrit-Change-Number: 22239 Gerrit-PatchSet: 5 Gerrit-Owner: Derek Huang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Derek Huang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 22 Dec 2024 17:38:40 +0000 Gerrit-HasComments: Yes
