Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22445 )
Change subject: KUDU-3596 fix one of the brittle assertions
......................................................................
KUDU-3596 fix one of the brittle assertions
The TsTabletManagerITest.TestTableStats scenario is very brittle due the
assumptions on various operations' timings. This patch addresses one
of them, replacing SleepFor(...) with more robust
InternalMiniCluster::WaitForTabletServerCount() condition.
The motivation for this changelist was following assertion in dist-test
failure [1] from a built-and-test pre-commit build for unrelated patch:
src/kudu/integration-tests/ts_tablet_manager-itest.cc:785: Failure
Expected equality of these values:
live_row_count
Which is: 434
table_info->GetMetrics()->live_row_count->value()
Which is: 0
...
src/kudu/integration-tests/ts_tablet_manager-itest.cc:895: Failure
Expected: CheckStats(kRowsCount) doesn't generate new fatal failures in the
current thread.
Actual: it does.
[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738567082.3715745
Change-Id: Id8581ecc0368ca17c14bcfc578f3896c9515b819
Reviewed-on: http://gerrit.cloudera.org:8080/22444
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <[email protected]>
(cherry picked from commit c9ab243d7df46361eea548b39f1e52ff591c0c92)
Reviewed-on: http://gerrit.cloudera.org:8080/22445
Tested-by: Alexey Serbin <[email protected]>
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Yifan Zhang: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8581ecc0368ca17c14bcfc578f3896c9515b819
Gerrit-Change-Number: 22445
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
