Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22450 )
Change subject: [common] minor cleanup on RowBlock/RowBlockRow ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22450/1/src/kudu/common/rowblock.cc File src/kudu/common/rowblock.cc: http://gerrit.cloudera.org:8080/#/c/22450/1/src/kudu/common/rowblock.cc@40 PS1, Line 40: DCHECK_LE(n_rows_, std::numeric_limits<uint16_t>::max()); > Failed tests seem related to this change. Thanks for checking this out. For some reason, I assumed that all SelectionVector instances should be less than 64K rows, but that's not true. -- To view, visit http://gerrit.cloudera.org:8080/22450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5 Gerrit-Change-Number: 22450 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 05 Feb 2025 18:54:31 +0000 Gerrit-HasComments: Yes
