Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22483 )
Change subject: [common] small clean-up on PartialRow
......................................................................
[common] small clean-up on PartialRow
It's possible to use 'if constexpr' to enable compile-time optimisations
in template code since switching to C++17. This patch updates the
implementations of KuduPartialRow::{Set,SetSliceCopy}() methods to use
compile-time evaluation of 'type' and 'physical_type'. I also added
static_assert() and PREDICT_FALSE() in the modified code where it's
appropriate, and did a few other style-related updates.
Change-Id: I1b164eb7ec7f010e9228175a026aa63726a909c6
Reviewed-on: http://gerrit.cloudera.org:8080/22480
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Yifan Zhang <[email protected]>
(cherry picked from commit cc5f132032abf94dec22f666b637678388448afc)
Reviewed-on: http://gerrit.cloudera.org:8080/22483
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/common/partial_row.cc
1 file changed, 20 insertions(+), 14 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b164eb7ec7f010e9228175a026aa63726a909c6
Gerrit-Change-Number: 22483
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
