Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies ...................................................................... Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@19 PS17, Line 19: 3.4.1 > this dependency is 3.4.0 in the dependencies.gradle file It is now updated to 3.4.1 http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@44 PS17, Line 44: so this file : could be used in future when we compile with JDK 9 > I'm not sure the placement of that file makes sense at all: the module-info Answered in the other comment in the specific file. http://gerrit.cloudera.org:8080/#/c/22374/17//COMMIT_MSG@50 PS17, Line 50: erorr > typo: error Done http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl File build-support/verify_jars.pl: http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl@62 PS17, Line 62: META-INF/versions/9/module-info.class > I ran the verify_jars.py after building the java project with JDK8, however @Alexey This is not a bug but expected behavior as per the docs. It is to be placed under META_INF/versions/<version_number>/ in case of a multi release jar. If not it is to be placed in the root directory: https://docs.oracle.com/en/java/javase/16/docs/specs/jar/jar.html#multi-release-jar-files I think it makes sense to exclude this file while building the jar by specifying in build.gradle file. @Zoltan: Strange that I did not find that issue when I previously posted this patch in my environment and also in the buidl environments. Nevertheless, this seems to be coming form upgrading Hive 3.1.2->3.1.3 which doesn't address any CVEs so we can skip it for now and upgrade to Hive 4 directly when we are ready. http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle@26 PS17, Line 26: testImplementation > +1 on Alexey's question, the original compiles just fine. Hive 3.1.3 seems to have brought in this dependency. It is not clear from the changelist[1], but the kudu-hive tests are failing with the below error: Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.fs.BatchListingOperations We can skip this for now and upgrade directly to Hive 4 as there are no known CVEs being addressed by this. Let me know if you think otherwise. [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12346277&styleName=Html&projectId=12310843 -- To view, visit http://gerrit.cloudera.org:8080/22374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d Gerrit-Change-Number: 22374 Gerrit-PatchSet: 17 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 12 Mar 2025 00:26:36 +0000 Gerrit-HasComments: Yes
