Marton Greber has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22627 )
Change subject: [util] fix flakiness in threadpool-test
......................................................................
[util] fix flakiness in threadpool-test
There were reports about a few test scenarios failing intermittently
with errors like below on a very busy machine:
[ RUN ] ThreadPoolTest.TestThreadPoolWithNoMinimum
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:317: Failure
Expected equality of these values:
0
pool_->num_threads()
Which is: 1
[ RUN ] ThreadPoolTest.TestVariableSizeThreadPool
/root/Projects/kudu/src/kudu/util/threadpool-test.cc:459: Failure
Expected equality of these values:
1
pool_->num_threads()
Which is: 2
This patch fixes the issue, removing implicit assumptions on timings
of events that might not be true in the presence of scheduled anomalies.
This is a follow-up to fc8615c37eb4e28f3cc6bea0fcd5a8732451e883.
Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Reviewed-on: http://gerrit.cloudera.org:8080/22622
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit 0b5b5da6d30d792915a2e22646a3f554783fd678)
Reviewed-on: http://gerrit.cloudera.org:8080/22627
Reviewed-by: Marton Greber <[email protected]>
Tested-by: Marton Greber <[email protected]>
---
M src/kudu/util/threadpool-test.cc
1 file changed, 11 insertions(+), 12 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8caed555b2207d25a93105037d77bd579d160550
Gerrit-Change-Number: 22627
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
