Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22710 )
Change subject: [tablet] fix result status handling ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22710/3/src/kudu/tablet/tablet_bootstrap-test.cc File src/kudu/tablet/tablet_bootstrap-test.cc: http://gerrit.cloudera.org:8080/#/c/22710/3/src/kudu/tablet/tablet_bootstrap-test.cc@253 PS3, Line 253: SCOPED_TRACE(Substitute("entry $0", i)); why is this necessary here? http://gerrit.cloudera.org:8080/#/c/22710/3/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/22710/3/src/kudu/tablet/tablet_replica.cc@656 PS3, Line 656: void TabletReplica::RunLogGC() { Could you explain the reasoning behind this change? In essence this makes RunLogGC() only output an error log if it fails, if I understand correctly. This method is mostly used in tests, and it's only other place it is used in void LogGCOp::Perform(), which I guess is a void, so the Status gets lost anyway, but wouldn't it be better to add a CHECK_OK() there? -- To view, visit http://gerrit.cloudera.org:8080/22710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5407906f2bf65e9a8798233f0280591e6e975cf Gerrit-Change-Number: 22710 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 31 Mar 2025 09:25:05 +0000 Gerrit-HasComments: Yes
