Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21823 )
Change subject: KUDU-3608: REST API for Metadata Management ...................................................................... Patch Set 34: (1 comment) http://gerrit.cloudera.org:8080/#/c/21823/34//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21823/34//COMMIT_MSG@29 PS34, Line 29: Testing Existing test scenarios in this changelist as of PS34 doesn't provide adequate coverage for the new functionality. Consider adding more test coverage, especially for 'negative' scenarios when some parameters are missing, wrong type of HTTP methods are used, invalid JSON data is supplied (corrupted data, and just missing fields), etc. At least, I could see that with PS34 it's now easy to stage inadvertent DoS attacks by crashing Kudu masters once this code is compiled in and the REST server is enabled. -- To view, visit http://gerrit.cloudera.org:8080/21823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67f964c4f950edfde31772cafd5c3ed5d6b87413 Gerrit-Change-Number: 21823 Gerrit-PatchSet: 34 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 17:58:40 +0000 Gerrit-HasComments: Yes
