Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22910 )
Change subject: KUDU-3663: Support certificates signed with RSASSA-PSS for channel bindings ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/22910/2/src/kudu/security/cert.h File src/kudu/security/cert.h: http://gerrit.cloudera.org:8080/#/c/22910/2/src/kudu/security/cert.h@79 PS2, Line 79: WARN_UNUSED_RESULT > If you don't mind, I might leave this here to make it easier to backport. Sure, let's keep it here if it helps in back-porting or anything. It's just a nit :) http://gerrit.cloudera.org:8080/#/c/22910/2/src/kudu/security/cert.cc File src/kudu/security/cert.cc: http://gerrit.cloudera.org:8080/#/c/22910/2/src/kudu/security/cert.cc@28 PS2, Line 28: #include <functional> > I wonder what triggered this. Maybe NULL? Let's see what happens when I swi BTW, you could see why IWYU asked for that by running $KUDU_HOME/build-support/iwyu.py --from-git --verbose -- To view, visit http://gerrit.cloudera.org:8080/22910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26a25a43d778fd2f2fcf293ecb199133c675212b Gerrit-Change-Number: 22910 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 19 May 2025 20:45:18 +0000 Gerrit-HasComments: Yes
