Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22976 )
Change subject: [common] introduce ColumnSchemaBuilder ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22976/4/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/22976/4/src/kudu/common/schema.h@216 PS4, Line 216: typedef ColumnSchemaBuilder Builder; > nit: is this used anywhere? It's not. It seems I introduced it, but then figured out that ColumnSchemaBuilder is 2 symbols shorter than ColumnSchema::Builder :) OK, it's removed in PS5. -- To view, visit http://gerrit.cloudera.org:8080/22976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c21b459b24675d0702c91add27950d91975fad9 Gerrit-Change-Number: 22976 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 19:04:01 +0000 Gerrit-HasComments: Yes
