Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23062 )
Change subject: Fix -Wmaybe-uninitialized warnings on ARM/Rocky Linux builds ...................................................................... Patch Set 2: (2 comments) Thanks a lot for addressing the feedback! PS2 looks better, but there is a couple of items introduced with PS2 to address. http://gerrit.cloudera.org:8080/#/c/23062/2/src/kudu/cfile/index-test.cc File src/kudu/cfile/index-test.cc: http://gerrit.cloudera.org:8080/#/c/23062/2/src/kudu/cfile/index-test.cc@430 PS2, Line 430: rand() rand() goes over the same pseudo-random sequence from the same starting point if not seeded appropriately first, so this is effectively rather a fixed sequence of three bytes, not random. To make this random in Kudu test harness, SeedRandom() from test_util.h should be invoked before calling rand(). http://gerrit.cloudera.org:8080/#/c/23062/2/src/kudu/cfile/index-test.cc@431 PS2, Line 431: rand() Instead of calling rand() 3 times, maybe call it just once and use 3 bytes out of 4 bytes if returns? -- To view, visit http://gerrit.cloudera.org:8080/23062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6442c5b0d8087f6360916070299278fcc41d39b Gerrit-Change-Number: 23062 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 26 Jun 2025 18:12:16 +0000 Gerrit-HasComments: Yes
