Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23045 )
Change subject: Add REST API integration tests ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/integration-tests/master_authz-itest.cc@336 PS6, Line 336: opts.extra_master_flags.emplace_back("--user_acl=test-user,impala,alice"); > nit: you can now use opts.enable_rest_api = true; Done http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/integration-tests/master_authz-itest.cc@990 PS6, Line 990: // REST API Authorization Integration Tests > What do you think about creating a dedicated test class for the rest api au Makes sense, done. http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/integration-tests/master_authz-itest.cc@1084 PS6, Line 1084: string alter_json = CreateAlterTableJsonAddColumn("test_table"); : s = c.PostToURL > nit: maybe you can scope the code parts (just to avoid c, and c_new etc. mo Done http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/integration-tests/master_authz-itest.cc@1207 PS6, Line 1207: ASSERT_OK(CreateKuduTable(kDatabaseName, table_name)); > nit: same as above, you can scope user A and user B to avoid EasyCurl c; Ea Done http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/master/spnego_rest_catalog-test.cc File src/kudu/master/spnego_rest_catalog-test.cc: http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/master/spnego_rest_catalog-test.cc@317 PS6, Line 317: string leader_addr; > is this test correct? Done, I added the loop for all masters. http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/master/spnego_rest_catalog-test.cc@338 PS6, Line 338: *leader_idx = -1; > maybe you can also test the /leader endpoint that it is getting 401. Done http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/master/spnego_rest_catalog-test.cc@352 PS6, Line 352: static KuduRegex re("\"leader\":\"([^\"]+)\"", 1); > nit: is this comment correct? Isn't this testing table operations on the le No, it is not correct, thank you for pointing that out! Fixed. http://gerrit.cloudera.org:8080/#/c/23045/6/src/kudu/master/spnego_rest_catalog-test.cc@358 PS6, Line 358: ASSERT_OK(c.FetchURL(Substitute(" > I see that here we have this block to identify leader master in multiple pl Done -- To view, visit http://gerrit.cloudera.org:8080/23045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3ff0dfd67cbc2b5ed0454372dd2bcea71e2ba3 Gerrit-Change-Number: 23045 Gerrit-PatchSet: 7 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 08 Aug 2025 13:57:21 +0000 Gerrit-HasComments: Yes
