Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23056 )
Change subject: KUDU-1261 introduce Flatbuffers into thirdparty ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23056/7/src/kudu/benchmarks/serdes/arrays.proto File src/kudu/benchmarks/serdes/arrays.proto: http://gerrit.cloudera.org:8080/#/c/23056/7/src/kudu/benchmarks/serdes/arrays.proto@19 PS7, Line 19: test > Here and in arrays.fbs, would this be the final package name? As for these .fbs and .proto files under src/kudu/benchmarks: yes. As for similar .fbs file to be used for 1D array serialiazation: nope, and I posted a separate patch for that: http://gerrit.cloudera.org:8080/23364 http://gerrit.cloudera.org:8080/#/c/23056/7/src/kudu/benchmarks/serdes/arrays.proto@56 PS7, Line 56: validity > I believe this is to note null mask. Maybe a comment would help clarify? Right. I added more comments in the src/common/serdes/array1d.fbs file added in http://gerrit.cloudera.org:8080/23364. Do you want me to add more comments for these .proto and .fbs files under benchmarks as well? -- To view, visit http://gerrit.cloudera.org:8080/23056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c697b8d80cbbd2af4233d16806a230cedaa81a Gerrit-Change-Number: 23056 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Sep 2025 16:15:18 +0000 Gerrit-HasComments: Yes
