Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23844 )
Change subject: [tools] Add --preserve_table_ids flag to unsafe_rebuild ...................................................................... Patch Set 5: (2 comments) > Patch Set 4: > > (2 comments) Thanks for the thorough review! http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/master_rebuilder.cc@61 PS4, Line 61: If true, preserve the original table IDs from the " : "tablet servers' metadata instead of generating new ones. This is required when " : "--tserver_enforce_access_control is enabled, as the access control system validates " : "table IDs. It is also useful for mainta > The flag description mentions external systems, but based on the commit mes Great suggestion! You're absolutely right - the access control use case is the primary driver for this feature, and it should be prominently mentioned in the flag help text to help operators discover this flag when needed. In fact, I initially discovered this issue through kudu perf table_scan failing after a master rebuild when --tserver_enforce_access_control was enabled. The impact on external systems like Impala was identified during further investigation to understand the full scope of the problem. Now I've updated the flag description. http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/23844/4/src/kudu/tools/tool_action_master.cc@53 PS4, Line 53: #include "kudu/tools/ksck.h" > Is this test utility header used anywhere in this file? done. -- To view, visit http://gerrit.cloudera.org:8080/23844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ae4353564922312d646f0323271d804e32e3b0d Gerrit-Change-Number: 23844 Gerrit-PatchSet: 5 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 04:30:51 +0000 Gerrit-HasComments: Yes
